search

insolite / graphene-peewee-async

Graphene peewee-async integration
37 stars 9 forks source link

Pip 10 compatibility was added. #7

Closed art1415926535 closed 6 years ago

art1415926535 commented 6 years ago

Installing with pip 10 raises an error ImportError: No module named req

insolite commented 6 years ago

Thanks for PR. I've just realized that parse_requirements as well as the entire pip package isn't really intended to be used as a public API in code (pypa/pip#2286). In other words importing pip's stuff may break things at any moment again in future versions (perhaps it also already did in outdated ones). Moreover I've found a reason to not use requirements.txt here at all, which I also didn't know about before. So I'd rather replace this dependency with a static install_requires definition soon.

insolite commented 6 years ago

Done in #9 and released to v2.1.4