inspirehep / inspire-next

The INSPIRE repo.
https://inspirehep.net
GNU General Public License v3.0
59 stars 69 forks source link

global: bump invenio-schemas to ~26.0 #1884

Closed kaplun closed 7 years ago

kaplun commented 7 years ago

In general:

In authors:

In hep:

rikirenz commented 7 years ago

@kaplun I have a question for the first point: acquisition_source now captures also the ORCID of the user. Now we are doing this: https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/literaturesuggest/tasks.py#L186 Do you think is already implemented?

kaplun commented 7 years ago

Looks like, although the ORCID should simply go into a property called orcid, and without any prefix. https://github.com/inspirehep/inspire-schemas/blob/master/inspire_schemas/records/elements/acquisition_source.json#L14

I am not sure at this point what source should contain though. Let's discuss tomorrow IRL. Maybe @jmartinm has some insight about how everything was populated until now?

jacquerie commented 7 years ago

The actual target might end up being https://pypi.python.org/pypi/inspire-schemas/12.0.0. Progress towards this has been done in #1883, #1886, #1891, and #1894. Before starting to merge them I want to complete the plan begun in #1896, adding schema validity tests everywhere in the unit tests for HEP and HEPNames, so that most schema changes are detected by them (at worst, we'll need to add one more failing test).

kaplun commented 7 years ago

Yeah, as @michamos well spotted, I have botched 11.0.0, so indeed 12.0.0 is the good release.

michamos commented 7 years ago

@kaplun So what's the plan? for example 00300ee contain changes that are not compatible with version 12, as we now have a _private_notes array. Besides, 667__a from HepNames seem to be public instead of private notes (to be confirmed).

kaplun commented 7 years ago

@jacquerie indeed please take into consideration @michamos 's comment about the harmonization in _private_notes/public_notes that was just integrated.

kaplun commented 7 years ago

ready is the way of Waffle.io to say that the issue is ready to work on.

jacquerie commented 7 years ago

And that indeed was my point: it will be ready when the program started in #1896 is done.

jacquerie commented 7 years ago

This was hard, because we didn't have the technology to execute this when we started. This was also an epic, because executing it requires solving numerous other issues.

jacquerie commented 7 years ago

Fixed in #1918.