Closed kaplun closed 7 years ago
@kaplun I have a question for the first point: acquisition_source
now captures also the ORCID of the user.
Now we are doing this:
https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/literaturesuggest/tasks.py#L186
Do you think is already implemented?
Looks like, although the ORCID should simply go into a property called orcid
, and without any prefix.
https://github.com/inspirehep/inspire-schemas/blob/master/inspire_schemas/records/elements/acquisition_source.json#L14
I am not sure at this point what source
should contain though. Let's discuss tomorrow IRL. Maybe @jmartinm has some insight about how everything was populated until now?
The actual target might end up being https://pypi.python.org/pypi/inspire-schemas/12.0.0. Progress towards this has been done in #1883, #1886, #1891, and #1894. Before starting to merge them I want to complete the plan begun in #1896, adding schema validity tests everywhere in the unit tests for HEP and HEPNames, so that most schema changes are detected by them (at worst, we'll need to add one more failing test).
Yeah, as @michamos well spotted, I have botched 11.0.0, so indeed 12.0.0 is the good release.
@kaplun So what's the plan? for example 00300ee contain changes that are not compatible with version 12, as we now have a _private_notes
array. Besides, 667__a
from HepNames seem to be public instead of private notes (to be confirmed).
@jacquerie indeed please take into consideration @michamos 's comment about the harmonization in _private_notes
/public_notes
that was just integrated.
ready
is the way of Waffle.io to say that the issue is ready to work on.
And that indeed was my point: it will be ready
when the program started in #1896 is done.
This was hard, because we didn't have the technology to execute this when we started. This was also an epic, because executing it requires solving numerous other issues.
Fixed in #1918.
In general:
acquisition_source
now captures also theORCID
of the user. @rikirenz (in #1891)field_category
has been renamedinspire_category
. @rikirenz (in #1810)material.json
now provides an enum of valid materials used throughout the schemas. We need to discard any invalid material. @jacquerieIn authors:
667__a
<->_private_note
(simple string). @spirosdelviniotis (in #1883)701__g
has now an enum (elements/degree_type.json
). Invalid types should go to_degree_type
. @rikirenz (in #1894)elements/rank.json
) should be stored into_rank
. @spirosdelviniotisIn hep:
INSPIRE
role.raw_affiliations
now captures lists of raw affiliation (100__v
/700__v
) @spirosdelviniotis (in #1883)classification_number
is merged intokeywords
(be careful onschema
)document_type
now contains a limited enum. See: inspirehep/inspire-schemas#31 for how to apply this @kaplunpublication_type
with enum, see: inspirehep/inspire-schemas#31 @kaplunpublished
flag: see inspirehep/inspire-schemas#31 @kaplunspecial_collection
: see inspirehep/inspire-schemas#31 @kaplundois
have now normalizedmaterial
external_system_numbers
->external_system_identifiers
. No more TeXKeys here, no more obsoletetexkeys
(obsolete are appended)isbns
have now normalizedmaterial
(previouslymedium
). Also they should be stored without dashes.keywords
are the new orange. Check PDG/PACS support.license
now have normalized material. @spirosdelviniotis (in #1883)page_nr
->number_of_pages
. @spirosdelviniotis (in #1883)persistent_identifier
type
->schema
@spirosdelviniotis (in #1883)publication_info
:isbn
->parent_isbn
,reportnumber
->parent_report_number
@spirosdelviniotis (in #1883)thesis
->thesis_info
check enum @spirosdelviniotis (in #1883)thesis_supervisor
-> authors (see above)withdrawn
flag. @kaplun