search

inspirehep / inspire-next

The INSPIRE repo.
https://inspirehep.net
GNU General Public License v3.0
59 stars 69 forks source link

Refactor workflows templates #2080

Open david-caro opened 7 years ago

david-caro commented 7 years ago

Workflow templates (in https://github.com/inspirehep/inspire-next/tree/master/inspirehep/modules/workflows/static/js/inspire_workflows_ui/templates) need to be revised to make sure there is a clear division of templates for each type of workflow.

For example, details.html has become too big and contains logic for both hep and authors. Would be better if that template just had a switch statement to distinguish the workflow type and then render the appropriate template.

Same logic should be applied for the other templates.

jmartinm commented 7 years ago

I don't think templates should be moved. https://github.com/inveniosoftware-contrib/invenio-workflows-ui acts like the rest of invenio-foo-ui packages which is basically handling the main views and maybe permissions (with sample templates)

Templates are in the overlay and that eases development and finding where things are in the codebase.

jacquerie commented 7 years ago

Templates are in the overlay and that eases development and finding where things are in the codebase.

We could have both by continuing the submodules thing you started for inspirehep-search-js: code is neatly separated in repos, but you can grep easily the codebase as long as you checkout the submodules locally.

(If you remember there was a speed talk at dotScale about this approach: https://www.youtube.com/watch?v=ZVsDA6GhKOU.)

jmartinm commented 7 years ago

We could have both by continuing the submodules thing you started for inspirehep-search-js: code is neatly separated in repos, but you can grep easily the codebase as long as you checkout the submodules locally.

Right, I still think the disadvantage of having things spread out in inveniosoftware, inveniosoftware-contrib and inspirehep outweighs the benefits of testability and neat separation.

I am kind of ok with separating core packages that need to be reused and do not change often but when it comes to data model specific (such as templates) it is way more convenient to have in inspire-next.

jmartinm commented 7 years ago

@david-caro I have amended title/description to clarify more the task to be done.

david-caro commented 7 years ago

👍