inspirehep / inspire-next

The INSPIRE repo.
https://inspirehep.net
GNU General Public License v3.0
59 stars 69 forks source link

GUI: showing relevance proposal #3546

Open ksachs opened 6 years ago

ksachs commented 6 years ago

As sources for proposals we currently have

these informations are used in different functions defined in

inspirehep/modules/workflows/workflows/article.py 
inspirehep/modules/workflows/tasks/actions.py
inspirehep/modules/workflows/tasks/matching.py  (auto_approve)
inspirehep-search-js/blob/master/src/inspirehep-holdingpen-js/templates/inspirehep-holdingpen-js/results/results.html (color for keywords)
inspirehep-search-js/blob/master/src/inspirehep-holdingpen-js/templates/inspirehep-holdingpen-js/details/details_decision_hep.html  (color for keywords)

Still to come

Needed soon

color display for CORE references. This can be done in js, but it gets complicated. I would prefer a python function, store the proposal in extra-data, which is used in js to select the color/class.

Re-organize code?

My naive approach would have been one function called by the workflow (similar to is_record_relevant) for all relevance/reject/accept decisions. Which calls functions to

Which then leads to actions (auto-accept, auto-reject) and can be used for color-display and to highlight the button we are encouraged to click.

ksachs commented 5 years ago

This is how it could look like:

Display result of steps that are used to make a proposal for accept/core. If there is no information (e.g. no PACS, this line doesn't need to be displayed). Display information in color according to proposal (CORE, Accept, Reject, No-Proposal).

If the single proposals are combined to an overall proposal, highlight the corresponding button. For auto-accept records lowlight (not fully disable) the reject button. I.e. there are 3 levels: encourage - normal - discourage. Our proposal would be normal = transparent ; highlight = full color; lowlight = gray. If there is no overall proposal the buttons would have the same transparency.

It should be easy to change and add criteria for single proposals as well as for the overall proposal. It will be too complex for config parameters, but is should not be buried and scattered all over the code.

List view

image

Auto-accepted records

i.e. fully harvested journals / arXiv categories The overall proposal would be at least Accept

image

Detailed view

it can have more information; if it is the same info, the wording and layout should be the same as on brief (if possible re-use the code) image