instaclick / PDI-Plugin-Step-AMQP

AMQP Plugin for PDI
MIT License
10 stars 14 forks source link

# fix for lost port settings #21

Closed dshvedchenko closed 9 years ago

dshvedchenko commented 9 years ago

add handling Transformation Cancel

also I want to discuss BaseProcessor shutdown method, there we have to check that channel or connection are not closed before invoke close method, but TestCase assumed that we have always invoke close(). how can I modify testcase to fix this? , help me ,please

FabioBatSilva commented 9 years ago

Yes, you can change it !! Can you please also add new tests to cover cancel ?

dshvedchenko commented 9 years ago

I'm weak with this this test-mockup framework.

  1. need to modify shutdown code so it invokes shutdown only for not closed connection, this breaks test for shutdown.
  2. about Cancel - I will try to learn this test framework and finish cancel code itself, it is not canceling waiting consumer now

@FabioBatSilva But if possible , can you merge only lost port settings commit ???

FabioBatSilva commented 9 years ago

@dshvedchenko Done !