search

instaclustr / cassandra-exporter

Java agent for exporting Cassandra metrics to Prometheus
Apache License 2.0
73 stars 46 forks source link

Cassandra 4.0 support #108

Closed johndelcastillo closed 1 year ago

johndelcastillo commented 1 year ago

Add support for Cassandra 4.0+ clusters

mindaugaszilionis commented 1 year ago

Hi, nice to see some progress. When we can expect release?:)

benbromhead commented 1 year ago

Largely looks good to me, however I think a bunch of python cache files where checked in and should get cleaned up unless there is a good reason to have them in repo?

johndelcastillo commented 1 year ago

Removed the python guff, not needed.

greut commented 1 year ago

Thanks for the hard work! It could really have been a 0.10.0 release.

rajesh-sapkale commented 1 year ago

HI @johndelcastillo Thank you for your hard work. I get the following error and 0.9.12 does not seem to work for Cassandra 4.1

WARN [cassandra-exporter-harvester-defer-0] 2023-05-26 11:51:37,289 Harvester.java:191 - Failed to register collector for MBean org.apache.cassandra .metrics:type=Connection,scope=xx.xx.xx.xx_7001,name=Timeouts. java.lang.IllegalArgumentException: 'xx.xx.xx.xx_7001' is not an IP string literal. at com.google.common.net.InetAddresses.formatIllegalArgumentException(InetAddresses.java:987) at com.google.common.net.InetAddresses.forString(InetAddresses.java:143) at com.zegelin.cassandra.exporter.MetadataFactory.endpointLabels(MetadataFactory.java:71) at com.zegelin.cassandra.exporter.FactoriesSupplier.lambda$connectionMetric$17(FactoriesSupplier.java:474) at com.zegelin.cassandra.exporter.FactoriesSupplier$FactoryBuilder.lambda$withLabelMaker$0(FactoriesSupplier.java:73) at com.zegelin.cassandra.exporter.FactoriesSupplier$FactoryBuilder.lambda$build$1(FactoriesSupplier.java:99) at com.zegelin.cassandra.exporter.Harvester.lambda$registerMBean$0(Harvester.java:174) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)

I am grateful for any help