search

instea / Cestovne-prikazy

0 stars 0 forks source link

Check how leaves are reported through API #68

Closed sodik82 closed 3 years ago

sodik82 commented 3 years ago

check if vacation over weekend (or public holiday) is correctly reported.

JozefKamensky commented 3 years ago

Do you have an example of erroneous report ? If yes, please post it.

sodik82 commented 3 years ago

These are the data from other app using the API:

image

i.e. reporting D8 (full anual vacation) also for Sat-Sun.

I am not familiar with exact API nor the other app itself - thus I am suggesting to check the over-weekend vacation reporting case.

JozefKamensky commented 3 years ago

Current implementation marks every day between start and end of vacation as vacation day (including weekends or public holidays). Change it to not include weekends is easy, problem could be with public holidays (if there is no usable library for it).

jurajmatus commented 3 years ago

I don't know what API is provided by the application, but the core mechanism already counts with weekends and public holidays: tmp jXGpRR2Whr

Proper reuse of that code should do the trick.

sodik82 commented 3 years ago

UI already accounts these...

image

example with weekend and public holiday. (there is some 3rd party library used)