search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.71k stars 2.52k forks source link

Submission Upload Causes Failure #1172

Closed austince closed 6 years ago

austince commented 6 years ago

Summary:

Submitting assignments via upload sometimes fails on Chrome, and JS error is thrown.

Steps to reproduce:

  1. Go to an assignment
  2. Click choose file
  3. Click Submit

Expected behavior:

Uploading a submission shouldn't fail.

Additional notes:

My system:

The Error is:

Uncaught TypeError: Cannot read property 'errors' of undefined
    at HTMLIFrameElement.A (vendor.bundle-4e4b4c4a29.js:1)
    at HTMLIFrameElement.<anonymous> (vendor.bundle-4e4b4c4a29.js:1)
    at HTMLIFrameElement.dispatch (vendor.bundle-4e4b4c4a29.js:1)
    at HTMLIFrameElement.s (vendor.bundle-4e4b4c4a29.js:1)
    at Object.trigger (vendor.bundle-4e4b4c4a29.js:1)
    at init.triggerHandler (vendor.bundle-4e4b4c4a29.js:1)
    at HTMLIFrameElement.onload (95450:1)

On Firefox, however, I get no such error.

Please let me know if this is a known error! Thanks!

simonista commented 6 years ago

Hey @austince, thanks for the bug report. unfortunately, since the js code is minified, that stack trace isn't very useful. You say "sometimes"... any way to narrow that down to be more reproducible? Or if not, how often would you say "sometimes" is?

skeetidot commented 6 years ago

This issue also happens when uploading attachments to an email in the Inbox.

The upload failure happens all the time for me in Chrome, but I am able to upload in IE 11.

I read that this may occur because of the LastPass password manager extension, which I use in Chrome, but I have LastPass version 4.5, and the issue was supposedly resolved in version 4.1. https://community.canvaslms.com/thread/15233-lastpass-incompatible-with-assignment-submission

austince commented 6 years ago

Hey @simonista, apologies for the late response - back at school now. Yes, for every upload on Chrome it fails.

simonista commented 6 years ago

Hi @austince and @skeetidot. I'm not able to reproduce this. I just tested uploading a file to an assignment in Chrome 64 on our production instance and it worked just fine. I think chrome extensions are a possible culprit -- you might try disabling one by one and testing to see if you can find a culprit. I think you'll also have more luck getting help through the normal help channel (see https://guides.instructure.com/m/4212/l/710328-how-do-i-get-help-with-canvas-as-a-student). That channel sees lots of help requests like this and may have more ideas or have seen patterns recently.

Hope that helps!