instrumentisto / medea

[Closed] Medea media server
Mozilla Public License 2.0
23 stars 3 forks source link

Fix deduping on force update in Jason (#27) #134

Closed evdokimovs closed 4 years ago

evdokimovs commented 4 years ago

Part of #27

Synopsis

If answerer sends UpdateTrack before offerer sent his SDP offer, then Event order on the answerer side will be incorrect.

Steps to reproduce

Add some delay to the Event::TracksApplied handler with NegotiationRole::Offerer in the Jason.

  1. Initial negotiation happened
  2. Alice mutes video
  3. Alice unmutes video
  4. Bob mutes video
  5. Alice sends SDP offer

What is the current bug behavior?

Alice's Sender will be muted.

What is the expected correct behavior?

Alice's Sender should be not muted.

Solution

Merge TrackPatches from the track_changes_queue with a TrackPatches from the pending_track_updates on force update.

Checklist

evdokimovs commented 4 years ago

FCM

Fix deduping on force update in Jason (#134, #27)
alexlapa commented 4 years ago

@tyranron ,

Тревису что-то с пятницы очень плохо, давайте пока без CI мержить.

UPD: Спустя 4 часа CI таки докрутился.