search

int-brain-lab / iblrig

Main repository for IBL rig code
https://int-brain-lab.github.io/iblrig/
MIT License
22 stars 22 forks source link

Show dialogs with append #599

Closed k1o0 closed 10 months ago

k1o0 commented 10 months ago

When append is true, the weighing dialog is only shown on the first protocol. All other dialogs are shown, although I noticed that the wizard arg only controls whether the poop count dialog is shown - it doesn't affect the weighing dialog. I left that behaviour alone although it is confusing and the difference between interactive and wizard should be clarified in the documentation. The effect of the append arg on the weighing dialog is covered by tests. I have not tested whether the online plots appear when append is true, however interactive is no longer affected by the state of append.

samupicard commented 10 months ago

Thanks for fixing this @k1o0. @oliche shall i wait for this to be pushed to the main iblrigv8 branch?