search

intacct / intacct-sdk-js

Official repository of the Sage Intacct SDK for JavaScript in Node.js
https://developer.intacct.com/tools/sdk-node-js/
Apache License 2.0
23 stars 33 forks source link

Formatting Log Files Removed #65

Open jimmymcpeter opened 3 years ago

jimmymcpeter commented 3 years ago

The update from v1.3.0 to v2.0.0 in src/Logging/MessageFormatter.ts removed the ability to format log files. Any idea why was this done? It's made formatting logs in development/production impossible. The SDK example extra credit section is also broken.

Here is the diff removing it -- https://github.com/Intacct/intacct-sdk-js/compare/v1.3.0...v2.0.0#diff-7d48fced524816f005557442ea6c9f1dcd4ad44344da5fa7a97fafc7d68f802dL88-L192

dylan-holt-sage commented 2 years ago

@jimmymcpeter, I am not sure why it was removed, occurred before I joined and the person who made the change is no longer in the company..... Will take a look on this for the release after the currently planned one.

dylan-holt-sage commented 2 years ago

@jimmymcpeter , I've re-added the formatting to how it was..... I'll take care of the "extra credit" fix after the upcoming release cycle is kicked off. Looking at Monday the 25th for that since it's part of our examples repo. Once that is taken care of, I'll be closing this issue :)

vclayton commented 1 year ago

I'm curious about the status of this issue. I've looked around and can't seem to find the changes mentioned in #95 anywhere.