intake / intake_geopandas

An intake plugin for loading datasets with geopandas
BSD 2-Clause "Simplified" License
15 stars 7 forks source link

test is failing for new version of geopandas #11

Closed Gijs-Koot closed 4 years ago

Gijs-Koot commented 4 years ago

geopandas version 0.6 now uses the pandas extension array system. The datatype for a geometry column in a geopandas.GeoDataFrame is now geometry, it used to be object. As a result, the test in tests/test_file_source.py is failing with the following error

def test_shape_datasource(shape_datasource):
        info = shape_datasource.discover()

>       assert info['dtype'] == {'name': 'object',
                                 'marker-col': 'object',
                                 'marker-sym': 'object',
                                 'line': 'object',
                                 'geometry': 'object'}
E       AssertionError: assert {'geometry': ...'object', ...} == {'geometry': ...'object', ...}
E         Omitting 4 identical items, use -vv to show
E         Differing items:
E         {'geometry': 'geometry'} != {'geometry': 'object'}
E         Use -v to get the full diff

tests/test_file_source.py:35: AssertionError
ian-r-rose commented 4 years ago

Thanks for the report @Gijs-Koot!