search

integr8ly / application-monitoring-operator

Operator for installing the Application Monitoring Stack on OpenShift (Prometheus, AlertManager, Grafana)
Apache License 2.0
30 stars 45 forks source link

label alertmanager service #147

Closed pb82 closed 3 years ago

pb82 commented 3 years ago

Label the alertmanager service to propagate the label down to the alertmanager endpoint. This endpoint is already scraped by an existing prometheus service monitor.

So by only adding this label we get all the alertmanager metrics that are relevant for INTLY-6634.

@david-martin does this approach make sense for you (modifying the RHMI1 AMO) or would you prefer to label the service in ansible?

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/integr8ly/application-monitoring-operator/blob/v0/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
david-martin commented 3 years ago

@pb82 Sure, if you're happy to do a v0 release.

existing prometheus service monitor

Which service monitor is this and what creates it?

pb82 commented 3 years ago

@david-martin it's the prometheus service monitor and we create it: https://github.com/integr8ly/application-monitoring-operator/blob/master/templates/prometheus-servicemonitor.yaml

it watches all endpoints in the namespace that have the monitoring label and a web port.