search

intel / IA-Hardware-Composer

35 stars 81 forks source link

Pass VTS for setBrightness API #719

Closed yuanzhel closed 3 years ago

yuanzhel commented 3 years ago

Tracked-On: OAM-96695 Signed-Off-By: Liu, Yuanzhe yuanzhe.liu@intel.com

yuanzhel commented 3 years ago

@yuanzhel pls. modify the commit message/title to describe what is changed and what it is for.

Done. Please kindly give me +2 review for further merge.

Shao-Feng commented 3 years ago

If it is related with capability, should we checking the capability list before returning Unsupported?

YuanjunHuang commented 3 years ago

If it is related with capability, should we checking the capability list before returning Unsupported?

This fix is being requested urgently. Suggest merge it first. Yes agree we shall add real implementation later.

yuanzhel commented 3 years ago

If it is related with capability, should we checking the capability list before returning Unsupported?

Seems now our getCapability never return display::brightness cap, but if it does further, guess this unsupport return will cause VTS failure again.