search

intel / intel-xpu-backend-for-triton

OpenAI Triton backend for Intel® GPUs
MIT License
143 stars 44 forks source link

Merge OpenAI Triton commit `86a2ac7` #2630

Closed anmyachev closed 2 weeks ago

anmyachev commented 2 weeks ago

This PR change the Triton base from https://github.com/intel/intel-xpu-backend-for-triton/commit/1d5fdfe9772cac77d675ea7798145fe467e63526 to https://github.com/intel/intel-xpu-backend-for-triton/commit/86a2ac753befe5286a261ba3b64eb40bdcca5704 (Oct 28). Pass rate: 99.83%->97.41%

Please do not squash and merge this PR.

anmyachev commented 2 weeks ago

@whitneywhtsang I am ending this and stopping this activity for now as agreed with you offline :)

anmyachev commented 2 weeks ago

@whitneywhtsang ready for review

whitneywhtsang commented 2 weeks ago

Is the pass rate degradation solely due to test_scaled_dot? Can we open an issue to fix that?

anmyachev commented 2 weeks ago

Is the pass rate degradation solely due to test_scaled_dot? Can we open an issue to fix that?

Yes, simply because the number of parameter combinations has increased, before this PR this test also did not work on XPU. Will open.

anmyachev commented 2 weeks ago

https://github.com/intel/intel-xpu-backend-for-triton/issues/2633

whitneywhtsang commented 2 weeks ago

Is the pass rate degradation solely due to test_scaled_dot? Can we open an issue to fix that?

Yes, simply because the number of parameter combinations has increased, before this PR this test also did not work on XPU. Will open.

Looks like to the number of test cases are unchanged, but this PR marks the failures as skipped instead of xfailed, that's why pass rate is affected.

anmyachev commented 2 weeks ago

Is the pass rate degradation solely due to test_scaled_dot? Can we open an issue to fix that?

Yes, simply because the number of parameter combinations has increased, before this PR this test also did not work on XPU. Will open.

Looks like to the number of test cases are unchanged, but this PR marks the failures as skipped instead of xfailed, that's why pass rate is affected.

Ah, it increased only for AMD, I see.