search

intel / isa-l_crypto

Other
267 stars 80 forks source link

fix redefined warning on aarch64 when using autoconf 2.71 #126

Closed chenxuqiang closed 8 months ago

chenxuqiang commented 10 months ago

Fix compilation warning: issues #124

pablodelara commented 10 months ago

Thanks @chenxuqiang. Anyone from ARM/using ARM that can review this?

docularxu commented 9 months ago

I'm from Linaro.org, and I worked in the Arm/Aarch64 ecosystem. Based on my test on Arm/Aarch64, this change resolved the mentioned compilation warning when using autoconf 2.71 : https://github.com/intel/isa-l_crypto/issues/124.

I will give it a pass. However, I have one question:

  1. @chenxuqiang Have you verified this change with autoconf version 2.69 and 2.70? Although I am not sure what type of test coverage can be enough. @pablodelara and @chenxuqiang you can give us some ideas. Thank you.

I noticed that in 'configure.ac', it defined this version requirement, that's why I'm asking for 2.69 and 2.70.

https://github.com/intel/isa-l_crypto/blob/46a0dff78d55b00a33b45f10bd48e24389624094/configure.ac#L4

chenxuqiang commented 9 months ago

I verified the above modifications using autoconf 2.69 and autoconf 2.70, respectively, and passed on both AARCH64 and X86.

docularxu commented 9 months ago

Thanks @chenxuqiang With that, I'm +1 on this patch.

pablodelara commented 8 months ago

Merged in f2e0339, thanks!