search

intel / ledmon

Enclosure LED Utilities
GNU General Public License v2.0
72 stars 44 forks source link

FIX possible memflood #178

Closed allanlaal closed 9 months ago

allanlaal commented 9 months ago

after 35 days up, ledmon takes too much RAM:

Private  +   Shared  =  RAM used    Program
3.6 GiB +  10.5 KiB =   3.6 GiB ledmon
peluse commented 9 months ago

might be good to consider adding a quick https://valgrind.org/ test for each PR

tasleson commented 9 months ago

after 35 days up, ledmon takes too much RAM:

Are you using a packaged version (provide what version), or building from source repository (provide what commit)?

Thanks

mtkaczyk commented 9 months ago

@allanlaal, please provide more details as @tasleson requested. We need to know if it is a recent problem introduced with library. Then, we can start investigation.

allanlaal commented 9 months ago

it was in ubuntu 23.04 before version 0.95-2 sadly couldn't find what that previous version was I'll reopen when I encounter it again

mtkaczyk commented 9 months ago

Thanks for feedback! The one option I'm considering here is to add valgrind to CI. Unfortunately, we don't have yet ledmon tests in CI so it must wait.

Thanks, Mariusz