search

intel / libva

Libva is an implementation for VA-API (Video Acceleration API)
http://intel.github.io/libva/
Other
664 stars 303 forks source link

Add mono_chrome to VAEncSequenceParameterBufferAV1 #691

Open rosetta-jpn opened 1 year ago

rosetta-jpn commented 1 year ago

To chroma subsampling completely, it is required to set mono_chrome. See https://aomediacodec.github.io/av1-spec/#color-config-semantics

In fact, VADecPictureParameterBufferAV1 has mono_chrome variable, but VAEncSequenceParameterBufferAV1 doesn't have. It is necessary to add mono_chrome to VAEncSequenceParameterBufferAV1.

rosetta-jpn commented 1 year ago

Friendly ping?

XinfengZhang commented 1 year ago

@rosetta-jpn because current intel implementation does not support it, but indeed , maybe need add it for common usage, do you know which vender are using it? will you file an PR to add it?

rosetta-jpn commented 1 year ago

I think no vendor supports mono_chrome today. It should be there for completeness. I will add it.

rosetta-jpn commented 1 year ago

Created pull request https://github.com/intel/libva/pull/697