search

intel / libva

Libva is an implementation for VA-API (Video Acceleration API)
http://intel.github.io/libva/
Other
664 stars 303 forks source link

Correct the av1 enc API; byte_offset_frame_hdr_obu_size is necessary #723

Closed rosetta-jpn closed 10 months ago

rosetta-jpn commented 1 year ago

The libva states the offset values of VAEncPictureParameterBufferAV1 are ignored in CQP mode. However, the produced bitstream is corrupted in fact if they are not filled in CQP mode.
As far as we talked with media-driver folks, byte_offset_frame_hdr_obu_size needs to be filled even in CQP mode. Indeed, a driver can read the offset from the packed headers, but it seems to be reasonable for an app to fill it.

So I think it would be better to correct the API; byte_offset_frame_hdr_obu_size needs to be filled regardless bitrate modes.

XinfengZhang commented 1 year ago

thanks for reporting， will file PR to fix it ASAP

XinfengZhang commented 1 year ago

and there are one WA , which could work before libva fix merged. https://github.com/intel/media-driver/pull/1691

rosetta-jpn commented 10 months ago

Any update?

XinfengZhang commented 10 months ago

726 was merged, then this issue could be closed?

rosetta-jpn commented 10 months ago

Yes, SGTM.