search

intel / libva

Libva is an implementation for VA-API (Video Acceleration API)
http://intel.github.io/libva/
Other
664 stars 303 forks source link

va: Fix -Wl,--version-script check with LLD 17 #732

Open vimproved opened 1 year ago

vimproved commented 1 year ago

In the upcoming LLD 17 (and previously in LLD 16.0.0, but reverted in 16.0.1), --no-undefined-version is becoming the default behavior. This causes the configure check for --version-scripts support to fail due to the symbols in the version script not being defined, which will cause the version script to not be used, and the build will fail due to --no-undefined-version. This commit adds '-Wl,--undefined-version' to the args of the configure check.

XinfengZhang commented 1 year ago

@vimproved , could you help to address the action issue?

vimproved commented 1 year ago

@vimproved , could you help to address the action issue?

Yes, sorry. I've been meaning to look at this for a while now, since I think this PR is not the best approach.

vimproved commented 1 year ago

Updated this PR with a different method of fixing that should be more correct.