intel / rohd-hcl

A hardware component library developed with ROHD.
https://pub.dev/packages/rohd_hcl
BSD 3-Clause "New" or "Revised" License
81 stars 23 forks source link

[MultiCycleDivider] Patch of prior bug fix to properly support unsigned division #141

Closed kimmeljo closed 1 day ago

kimmeljo commented 4 days ago

Description & Motivation

This patch addresses a bug in the previous fix for MultiCycleDivider (proper support for unsigned division) that caused certain division operations to be performed incorrectly due to checking of improper bits.

Related Issue(s)

Testing

Added an explicit unit test on a known case where pre-patch functionality was broken.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

This is fully backwards compatible as the patch is entirely internal to the implementation.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No explicit documentation was required for the patch but documentation was still enhanced to discuss performance of the module in more detail (motivated by this fix).