search

intelllex / react-pdf

Simple and fancy PDF Viewer based on pdf.js 📄⚡️
https://intelllex.github.io/react-pdf
119 stars 34 forks source link

Feature request for "Print" option #8

Open ghanshyam-1805 opened 3 years ago

ghanshyam-1805 commented 3 years ago

Is possible to add a print option in the toolbox?

trinhngocdieu commented 3 years ago

hi @ghanshyam-1805 , yes, it is possible, but right now our react-pdf has had it yet. How about we provide an option to add a print icon? When the user clicks on the print icon, we will save that pdf to your device?

ghanshyam-1805 commented 3 years ago

There will be good if the native print popup will be open on click of the print icon, the Download option will be a new feature if anyone required.

ghanshyam-1805 commented 3 years ago

@trinhngocdieu What's your suggestion?

trinhngocdieu commented 3 years ago

@ghanshyam-1805 , sorry for late response. I think it is possible, I will update and let you know soon.

ghanshyam-1805 commented 3 years ago

@trinhngocdieu Thanks.

ghanshyam-1805 commented 3 years ago

@trinhngocdieu I have found one issue and enhancement,

1) Zoom issue: When we continuously press the "zoom-out" button it throws an error in the console that "PDFViewer._setScale: "-0.19999999999999996" is an unknown zoom value." and PDF got invisible. 2) Enhancement: While scrolling the PDF, thumbnails should also scroll according to the page.

It would be great if you look at these also.

Thanks!

trinhngocdieu commented 3 years ago

@ghanshyam-1805 : Thank you so much, I will try to look and fix them soon. It would be great if you can create a PR, too! :)