search

interactionresearchstudio / NaturewatchCameraServer

A Python / OpenCV camera server to stream Pi camera content to a remote client through a website.
https://mynaturewatch.net
GNU General Public License v3.0
103 stars 49 forks source link

Add pagination to Photos page #11

Closed frak closed 5 years ago

frak commented 5 years ago

Please add ?w=1 to the diff URL of this PR to ignore the whitespace changes that were made by PyCharm, I had gotten too far into the changes before I realised I had cleaned it out of habit.

The requests to get the data are still slow when the file list is large, but caching a file directory that could be being written to would be difficult to keep in sync, so I have left this as is.

I have had to update the css file by hand as I don't know how to build your assets automatically.

mikevanis commented 5 years ago

Hi @frak, thanks for the PR. I have added information in the readme to walk you through how to compile the Less stylesheet. If you could move over the new CSS to the styles.less file and compile it into the styles.css file, that would be great. That way we can keep the two in sync!

mikevanis commented 5 years ago

Reviewing the code changes now, it looks like you managed to compile the less file already. Is that right?

frak commented 5 years ago

No, I just added the change manually to both places :) Not sure I need to build anything right now, but going forward I will use your instructions to rebuild the assets rather than working by hand.

mikevanis commented 5 years ago

Ok cool, I'll test this on my unit and merge away!

frak commented 5 years ago

Should all be good to go now

mikevanis commented 5 years ago

Thanks, I've tested on a unit here and merged. There are a few CSS tweaks but I'll try and get them done this week. Good work! 👍