github-management-service
commented
2 months ago It looks like you are reviewing a Dependabot upgrade PR! 🛠️ That’s great! Keeping our packages up to date to fix security issues in our stack is super important. Team Application Security wants to help make this process as easy and low friction as possible while still moving at pace.
We aim to merge Dependabot PRs within the below timeframes. The objectives are based on the severity of the security vulnerability we are mitigating with the upgrade:
| Severity | Target Merge (days) |
|---|---|
| CRITICAL | 7 days |
| HIGH | 14 days |
| MEDIUM | 30 days |
| LOW | 90 days |
🎯 Target merge date for this PR: 25/09/2024 🎯
FAQ
What if we aren’t vulnerable to this particular CVE? Do we still have to upgrade the package?
It’s still a good idea to upgrade the package if we can. With new code patterns and paths being introduced every day, we have no guarantee that we won’t later make ourselves vulnerable. Keeping packages up to date as a matter of due course is also good hygiene.What if we’re not vulnerable and upgrading is going to be a lot of work?
In these cases it’s a good idea to list out the steps you took to confirm we are not vulnerable in this PR. The PR can then be closed and the corresponding Dependabot Alert should be dismissed with the triage steps included as a comment. Please get in touch with Team Application Security via #ask-security before dismissing anyCRITICAL alerts.
This is a major version upgrade that requires substantial code refactoring. What should I do?
If the upgrade requires substantial refactoring then it is possible that we will miss the objectives we have outlined above. In these cases, you should add thedependabot-refactor-required label to this PR and ping #ask-security for further advice.
dependabot[bot]
Fixes intercom/intercom#355112. Bumps path-to-regexp from 1.8.0 to 1.9.0.
Release notes
Sourced from path-to-regexp's releases.
Commits
c75eb101.9.0925ac8eAdd backtrack protection to 1.x release (#320)32a14b0Fixre.exec('/test/route')result (#267)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show