search

intercom / intercom-rails

The easiest way to install Intercom in a Rails app.
https://developers.intercom.io/reference
MIT License
281 stars 108 forks source link

[Performance] Improve memory usage and object retention #319

Closed ahorek closed 4 years ago

ahorek commented 4 years ago

Why?

https://github.com/intercom/intercom-rails/pull/277

I run into the same issue as the original author.

How?

I rebased the original PR and fixed mentioned problems based on feedback.

swrobel commented 4 years ago

@jonnyom any hope of getting this reviewed & possibly merged or is this gem abandonware?

swrobel commented 4 years ago

@sduquej any hope of getting this reviewed & possibly merged or is this gem abandonware?

sduquej commented 4 years ago

This looks great, thanks @ahorek, @clowder (and @swrobel for the nudge)! I just have a couple of minor suggestions. I should have time this week to review it and cut a new release including these changes.