search

interledger-deprecated / ilp-plugin-bells

ILP Ledger plugin for five-bells-ledger
Other
4 stars 8 forks source link

fix: refresh auth token every 7 days #136

Closed sentientwaffle closed 7 years ago

sentientwaffle commented 7 years ago

Depends on https://github.com/interledgerjs/ilp-plugin-bells/pull/132 and https://github.com/interledgerjs/five-bells-ledger/pull/425 and https://github.com/interledgerjs/five-bells-ledger/pull/429

codecov-io commented 7 years ago

Codecov Report

Merging #136 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #136      +/-   ##
=========================================
+ Coverage   96.24%   96.3%   +0.05%     
=========================================
  Files          11      11              
  Lines         799     811      +12     
  Branches      180     182       +2     
=========================================
+ Hits          769     781      +12     
  Misses         30      30
Impacted Files Coverage Δ
src/lib/factory.js 95.27% <100%> (ø) :arrow_up:
src/lib/plugin.js 98.23% <100%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00dc93a...6baab1c. Read the comment docs.

emschwartz commented 7 years ago

I think it might be better to have the ledger actually tell you how long the token is valid for (with cache headers or an expiry date) so the plugin knows when it needs to reconnect. Otherwise the actual time we implement would have to be considered part of the ledger protocol (what if someone sets a shorter time than what the plugin assumes?)

sentientwaffle commented 7 years ago

Merged as part of https://github.com/interledgerjs/ilp-plugin-bells/pull/137