search

interledger-deprecated / ilp-plugin-bells

ILP Ledger plugin for five-bells-ledger
Other
4 stars 8 forks source link

Feat: use message.data as a fallback if no ilp #142

Closed sharafian closed 7 years ago

sharafian commented 7 years ago

Supports old version of the five bells ledger API where there are no id, ilp, nor custom fields. It will send message calls that have both data and id ilp custom set.

codecov-io commented 7 years ago

Codecov Report

Merging #142 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   95.82%   95.84%   +0.01%     
==========================================
  Files          11       11              
  Lines         839      842       +3     
  Branches      190      193       +3     
==========================================
+ Hits          804      807       +3     
  Misses         35       35
Impacted Files Coverage Δ
src/lib/plugin.js 98.08% <ø> (ø) :arrow_up:
src/lib/translate.js 93.44% <100%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3eb337f...95d083b. Read the comment docs.

sentientwaffle commented 7 years ago

Depends on https://github.com/interledgerjs/five-bells-ledger/pull/430 for tests to pass

emschwartz commented 7 years ago

Tests already passed with this change so I'm going to merge it now (just needed to rebase on top of master to merge)