interledger-deprecated / ilp-plugin-bells

ILP Ledger plugin for five-bells-ledger
Other
4 stars 8 forks source link

Plugin sends empty authentication if username is not specified #145

Closed sharafian closed 7 years ago

sharafian commented 7 years ago

If the plugin is created with only account and password, the requestCredentials function will send no authentication during the connect function. Passing the username into the plugin parameters appears to fix this.

dappelt commented 7 years ago

ilp-plugin-bells makes an unauthenticated request to /accounts/:name to resolve the username. As just discussed, in your particular scenario the username was not resolved because unauthenticated requests to the endpoint are disallowed.

To fix this, you have two options: 1) Make your ledger compliant with fb-ledger and allow unauthenticated requests to /accounts/:name. 2) Pass in the username when instantiating the plugin.

sharafian commented 7 years ago

Looks like this was caused by a ledger problem, not a plugin one