interledger / interledger-rs

An easy-to-use, high-performance Interledger implementation written in Rust
http://interledger.rs
Other
201 stars 70 forks source link

fix(packet): add precheck for timestamps in Prepares #707

Closed whalelephant closed 3 years ago

whalelephant commented 3 years ago

Cc: #705 Check if bytes are numerical values before handing to chrono

koivunej commented 3 years ago

This is a correctness update which will deny some patterns which were previously accepted as valid timestamps, but did not adhere to RFC and the asn1 specification. The previously accepted timestamps can be seen with the test case. Merging slightly ahead of the 24h window.