search

interledger / interledger-rs

An easy-to-use, high-performance Interledger implementation written in Rust
http://interledger.rs
Other
201 stars 70 forks source link

Require unicase >= 2.6 to ensure correct username comparison #744

Closed amousset closed 1 year ago

amousset commented 2 years ago

When using unicase 2.5.1 the username comparison is not correct and substrings are considered equal due to https://github.com/seanmonstar/unicase/issues/38.

Requiring 2.6.0 (which is already used in the Cargo.lock) prevents the problem.

koivunej commented 2 years ago

Thanks for this, I'll figure out what's wrong with string escaping first in another PR.

koivunej commented 2 years ago

@amousset apologies, could you first refresh your master branch, then do a git rebase --signoff master and force-push? There's a repo requirement for signed off commits.