interledger / rafiki

An open-source, comprehensive Interledger service for wallet providers, enabling them to provide Interledger functionality to their users.
https://rafiki.dev/
Apache License 2.0
234 stars 83 forks source link

feat(2624): add design and modify flow in MASE #2741

Closed lengyel-arpad85 closed 3 months ago

lengyel-arpad85 commented 4 months ago

Changes proposed in this pull request

solves most of #2624

Screenshots (v2)

Screenshots (old)

Context

Checklist

netlify[bot] commented 4 months ago

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
Latest commit c657cc7c590d5cc9c0dd8b5045bfdb4311c7b778
Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6660bc1862d4970008e629bd
mkurapov commented 4 months ago

A few of us took a look at the screenshots, and had some comments:

In general, looks much better, thank you! The main thing we wanted to do was to distinguish it a bit more from the Admin UI, just to avoid any confusion for people working through the local playground, between what would be part of Rafiki, or something external.

Some thoughts we had:

I'll start a thread in slack in case someone else had additional thoughts.

JoblersTune commented 4 months ago

How about this for a different look: image We could have a different background for the wallet ASE using it's wallet svg instead of the banks.

JoblersTune commented 4 months ago

Colors:

Assets: wallet-white wallet-background background Bank Icon (1)

lengyel-arpad85 commented 4 months ago

A few of us took a look at the screenshots, and had some comments:

In general, looks much better, thank you! The main thing we wanted to do was to distinguish it a bit more from the Admin UI, just to avoid any confusion for people working through the local playground, between what would be part of Rafiki, or something external.

Some thoughts we had:

  • Adding the name of the instance (eg "Happy Life Bank" or "Cloud Nine Wallet") instead of "Mock ASE" , and adding some kind of icon to go along with it, either the wallet icon (like the one in the new test wallet/rafiki.money redesign) or the bank icon
  • Adding something like global disclaimer to the footer of the page, explaining that this is just a "Mock ASE" and not for use as a production interface
  • Mainly to differentiate from the Rafiki UI, there was an idea was to move the two tabs to the top of the page (at least somewhere other than the left side bar)
  • And in general, some minor changes in the color, to contribute to the separation between the mock ASE and Admin UI

I'll start a thread in slack in case someone else had additional thoughts.

The update: