search

interledger / rafiki

An open-source, comprehensive Interledger service for wallet providers, enabling them to provide Interledger functionality to their users.
https://rafiki.dev/
Apache License 2.0
234 stars 83 forks source link

fix!: typo in KRATOS_CONTAINER_PULIC_URL #2755

Closed JoblersTune closed 3 months ago

JoblersTune commented 3 months ago

Changes proposed in this pull request

Context

Checklist

netlify[bot] commented 3 months ago

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
Latest commit c249367be34f349cd19fec6df0e418d0cb384129
Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/665cba35591a12000854878c
JoblersTune commented 3 months ago

Seems we also need to add info about Kratos config in cases when people are using sub domains. Will address this once we are confident we have the full answer.

JoblersTune commented 3 months ago

Let's just fix the typo first. I'm making a separate issue to add comments about setting up Kratos on a subdomain.

@tadejgolobic you needed the env vars for the helm charts -> do you need to fix the typo there as well?

tadejgolobic commented 3 months ago

Let's just fix the typo first. I'm making a separate issue to add comments about setting up Kratos on a subdomain.

@tadejgolobic you needed the env vars for the helm charts -> do you need to fix the typo there as well?

Yes I do. I will fix that as soon you merge this PR.

JoblersTune commented 3 months ago

@tadejgolobic this has been merged now