search

interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.
Apache License 2.0
49 stars 3 forks source link

chore(ci/pr-checks): add lint checks #306

Closed sidvishnoi closed 3 months ago

sidvishnoi commented 3 months ago

Context

Part of https://github.com/interledger/web-monetization-extension/issues/298

Changes proposed in this pull request

Runs lint, format and typescheck in CI. Doesn't fail entire workflow if lint fails - for now. Added as separate steps for clearer output.

raducristianpopa commented 3 months ago

Extension builds preview

Name Link
Latest commit 40fb036b1d4a37a415907288cd7feba70fb386c5
Latest job logs Run #9414179912
BadgeDownload
BadgeDownload
sidvishnoi commented 3 months ago

Not getting the annotations, but it's better than nothing. https://github.com/actions/setup-node/issues/96

sidvishnoi commented 3 months ago

The failing lint check is for demonstration only. It's getting fixed in other PR.

raducristianpopa commented 3 months ago

The failing lint check is for demonstration only. It's getting fixed in other PR.

The error needs to be fixed, otherwise merging is blocked.

mkurapov commented 3 months ago

The error needs to be fixed, otherwise merging is blocked.

There doesn't seem to be any required checks to pass on this repo, just needs an approval.

What should be required? @sidvishnoi @raducristianpopa If you don't have permissions, I can make those changes

sidvishnoi commented 3 months ago

I think we can require all checks except lint?