search

interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.
Apache License 2.0
49 stars 3 forks source link

chore(deps): update dependencies #315

Closed sidvishnoi closed 3 months ago

sidvishnoi commented 3 months ago

Context

Instead of merging separate PRs and adding noise to commit log, maybe we should merge PRs combined weekly? This PR was generated with ncu. I've been using this approach on the open-source projects I maintain. We'd let dependabot/renovate generate PRs, but instead of merging each separately, we do this.

See also: https://github.com/interledger/web-monetization-extension/pull/270

Changes proposed in this pull request

  1. Closes #225
  2. Closes #304
  3. Closes #308
  4. Closes #309
  5. Closes #310
  6. Closes #312
  7. Closes #314
  8. and some more dependencies updated.
raducristianpopa commented 3 months ago

Extension builds preview

Name Link
Latest commit 34f4fe73038cd3e95b4657edf2b459c17b08f75d
Latest job logs Run #9449105029
BadgeDownload
BadgeDownload
raducristianpopa commented 3 months ago

I don't think we should batch all the dependencies updates. This way, we can easily revert the PR if things are not going as planned.

sidvishnoi commented 3 months ago

I'm of opinion that PR is the place where we check things are going right or not. Reverts are exceptional. Besides, non-major dependency updates are considered safe enough.

I'm mostly concerned about the noise in git log. We've more dependency commits than actual code commits.

sidvishnoi commented 3 months ago

From safety perspective, perhaps we can do certain updates (like open payments package) individually. Best of both?

sidvishnoi commented 3 months ago

Closing the PR as most dependencies are merged already, but would like a discussion on reducing the dependency PR noise sometime soon.