search

interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.
Apache License 2.0
49 stars 3 forks source link

[BUG] Extension not stopping me from connecting to a non WM payment pointer #331

Closed RabebOthmani closed 3 months ago

RabebOthmani commented 3 months ago

Steps to reproduce

  1. Connecting my extension to a wallet
  2. In the wallet address field, I use a payment pointer that is not WM enabled
  1. I click on the Connect button
  2. my extension is now connected to the wallet

Expected result

The extension should not be able to connect to a non WM pointer. Connection should fail with a clear error message explaining the reason to the user

Actual result

Extension connects but all payments fail leaving the user confused on why their payments are failing

Screenshots or videos

No response

Additional context

No response

Operating system

Windows

Operating system version

No response

Browsers

Chrome

Browser version

No response

Extension version

Alpha

raducristianpopa commented 3 months ago

At the moment, this is only a constraint on the test wallet - "WM Payment Pointer". The extension should work with any wallet address.

RabebOthmani commented 3 months ago

@tselit Do you think we should include this in some sort of documentation material as a limitation/constraint as we prepare for beta?

tselit commented 3 months ago

Cool, and thanks @RabebOthmani and @raducristianpopa . Yes, the goal is to enable testing the beta release with a wallet that uses any currency.

We'd documented this constraint as being relevant to the alpha release - here ➡️ Getting Started ➡️ Step 1 - Get a wallet.

Agreed that this is not a bug.