sappenin commented 5 years ago

The current Quickstart command is broken because the Connector does not stay running after issuing it.

This PR fixes this by enabling the AdminApi for this specific use-case. Without this additional directive, and because no accounts are defined in this quickstart command, there's nothing on the connector that's listening (no accounts and no admin API) and so there's nothing to keep the node process alive. With the admin API enabled it's running an http server, which will hold the connector process open.

jsf-clabot commented 5 years ago

All committers have signed the CLA.

codecov-io commented 5 years ago

Codecov Report

Merging #488 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files          44       44           
  Lines        1822     1822           
  Branches      309      309           
=======================================
  Hits         1217     1217           
  Misses        479      479           
  Partials      126      126

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03af2d1...d2994ab. Read the comment docs.

interledgerjs / ilp-connector

Add `CONNECTOR_ADMIN_API=true` to Quickstart #488

Codecov Report