Closed sharafian closed 4 years ago
Merging #495 into master will increase coverage by
0.11%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 66.64% 66.75% +0.11%
==========================================
Files 44 43 -1
Lines 1826 1802 -24
Branches 309 304 -5
==========================================
- Hits 1217 1203 -14
+ Misses 483 476 -7
+ Partials 126 123 -3
Impacted Files | Coverage Δ | |
---|---|---|
src/stores/memory.ts | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ff20aff...85ea68a. Read the comment docs.
The leveldown module packaged with the connector is unused in almost all cases and causes a plethora of build errors and other issues when installing the connector
👍
Even the balance middleware is typically not used in production so on most deployments no store is being used.
FYI, I think balances were always tracked entirely in-memory... https://github.com/interledgerjs/ilp-connector/issues/478
The leveldown module packaged with the connector is unused in almost all cases and causes a plethora of build errors and other issues when installing the connector. This PR removes the leveldown store and the memdown store and replaces them with a memory store that is functionally the same as the memdown one but doesn't require a dependency.
This is a breaking change. If there's interest in keeping the leveldown store around it could be moved into a standalone module but AFAIK nobody is still using it. Even the balance middleware is typically not used in production so on most deployments no store is being used.