interlock-network / threatslayer

A Chrome browser extension that protects you from malicious sites.
GNU General Public License v3.0
12 stars 3 forks source link

Dashed visual indicator improvement #14

Closed blairmunroakusa closed 2 years ago

blairmunroakusa commented 2 years ago

This improvement entails the following: . thicken dashed line by one px for better visibility . outline window.screen, instead of document.body . dashed line is responsive under resize and zoom events . bring dashed line box to front of pane and make sticky (does not get covered by menu bars, etc)

(Also, by setting box.style.pointerEvents to default, this canvas may be used to lock out an interlocker from interacting with a malicious website. box.style.pointerEvents = "none" allows interaction through the canvas.)

jmercouris commented 2 years ago

Fantastic change! I like it! Not sure how I feel about the comment, that is the only comment I have!

blairmunroakusa commented 2 years ago

Thank you!

I agree; I removed the comment.

Should I merge @jmercouris ? --or is it customary for the reviewer to merge? I am not used to this process.