Convert current banner implementation to iFrame

[blairmunroakusa]

The current banner implementation is not secure as it could be due to potential CSS interference.

Using an iFrame appears to be the closest equivalent implementation of such a banner.

Convert the current extension banner implementation to iFrame.

If iFrame doesn't work for some reason, then we may need to entertain using a popout window.

Please implement in this branch: iFrame-banner

[DecentralizedDan]

@blairmunroakusa

Dude. The problem with iframes is that you cannot remove an iframe from within the context / window of that iframe

• You can only close it from the parent context / window
• It appears that you lose context to the parent window and there's no way to access it from, or pass it to, the frame
• Therefore there is no way I know of to create a JS function in an iframe that can close it

Here's what I tried:

• I tried changing the iframe to display: none, which hid the iframe but continued to block interaction with the page underneath
• Changing the dimensions of the HTML in the iframe -- this changes the size of the elements shown on the iframe, but not the size of the window itself, so the underlying page still gets blocked
• Changing the dimensions of the iframe -- this is impossible without access to the parent window
• Removing the iframe -- same as changing its dimensions (impossible)