intermine / im-tables

Dynamic Result Table Library
Other
9 stars 27 forks source link

Unexpected behaviour of npm start #205

Closed jshreyans closed 4 years ago

jshreyans commented 4 years ago

Running npm start creates unexpected output on the console: Screenshot from 2020-02-09 11-45-15

The script for this command in the package.json specifies this command:

grunt run:server

but as above, the command simply outputs Done and exits This command is also a part of the CONTRIBUTING doc that allows first-time contributors to setup im-tables. I suggest we replace it with the npm run dev command.

yochannah commented 4 years ago

since there is a dev command that does work and not much use-case for running this on a standalone server, I suggest we simple do the following:

  1. remove the task for npm start
  2. remove it from the docs.

On Sun, 9 Feb 2020 at 06:17, Shreyans Jain notifications@github.com wrote:

Running npm start creates unexpected output on the console: [image: Screenshot from 2020-02-09 11-45-15] https://user-images.githubusercontent.com/41480918/74097414-b7f52b00-4b31-11ea-894d-90b207b41deb.png

The script for this command in the package.json https://github.com/intermine/im-tables/blob/dev/package.json specifies this command:

grunt run:server

but as above, the comand simply outputs Done and exits

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/intermine/im-tables/issues/205?email_source=notifications&email_token=ACGXRDRZMY5DIOTTE4HLLMLRB6NZBA5CNFSM4KR7QVT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IMBNLOQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGXRDR6M66CZGBMP4DMCULRB6NZBANCNFSM4KR7QVTQ .

-- Please note I am ‘working to contract’ as part of the UCU industrial action to defend our pensions and fight for fair pay and equality. This may mean it takes longer for me to respond to emails. You can find out more about the dispute at: www.ucu.cam.ac.uk/faqs http://www.ucu.cam.ac.uk/faqs

heralden commented 4 years ago

Could be worth having the start command run npm run dev instead. This is useful since npm start is the standard method to start a node program, so users might try typing it before reading the documentation. We would probably need to update the docs anyways.

yochannah commented 4 years ago

+1, good plan.

On Mon, 10 Feb 2020 at 14:01, Herald notifications@github.com wrote:

Could be worth having the start command run npm run dev instead. This is useful since npm start is the standard method to start a node program, so users might try typing it before reading the documentation. We would probably need to update the docs anyways.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/intermine/im-tables/issues/205?email_source=notifications&email_token=ACGXRDXI4RYTCIMA35D3VO3RCFM27A5CNFSM4KR7QVT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELITMFA#issuecomment-584136212, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGXRDQ7GXLZV4FNJAQRKHTRCFM27ANCNFSM4KR7QVTQ .

-- Please note I am ‘working to contract’ as part of the UCU industrial action to defend our pensions and fight for fair pay and equality. This may mean it takes longer for me to respond to emails. You can find out more about the dispute at: www.ucu.cam.ac.uk/faqs http://www.ucu.cam.ac.uk/faqs

jshreyans commented 4 years ago

@uosl that's a better idea I suppose. That way we won't have to completely depend on the fact that the user will read the entire doc before running the project. I'll make changes and submit a PR in some time.

jshreyans commented 4 years ago

@uosl @yochannah I've sent a PR for this. Should be fixed now!

heralden commented 4 years ago

Thanks for reporting and fixing! [=