search

intermine / im-tables

Dynamic Result Table Library
Other
9 stars 27 forks source link

Popups don't show too many items #218

Closed Manasa2850 closed 3 years ago

Manasa2850 commented 4 years ago

Solves #169

Note: The changes here work for all mines but I've focused primarily on yeast mine. Initially the popup for yeast mine had 40+ values. Now only 12 are shown. I have used details.get('type') == "String" so that it works for all mines. Having a for loop for(i=0; i<10; i++) will fail for mines having number of attributes less than 10. After looking at several mines, I've found that the number of attributes satisfying the type condition is a small number.

Screenshots: Flymine popup1

Yeastmine popup

heralden commented 3 years ago

I apologise for the very late feedback!

Thank you for looking into the issue. I think limiting to string values would exclude potentially useful information. And if we do truncate the amount of items, we should allow viewing the remaining items with a show more button (which is difficult to add, since the tooltip disappears when you try to interact with it).

I will be closing this PR as I'm not expecting a response after this long time. You are welcome to open another PR if you wish to tackle this issue again.