Closed Manasa2850 closed 3 years ago
I apologise for the very late feedback!
Thank you for looking into the issue. I think limiting to string values would exclude potentially useful information. And if we do truncate the amount of items, we should allow viewing the remaining items with a show more button (which is difficult to add, since the tooltip disappears when you try to interact with it).
I will be closing this PR as I'm not expecting a response after this long time. You are welcome to open another PR if you wish to tackle this issue again.
Solves #169
Note: The changes here work for all mines but I've focused primarily on yeast mine. Initially the popup for yeast mine had 40+ values. Now only 12 are shown. I have used
details.get('type') == "String"
so that it works for all mines. Having a for loopfor(i=0; i<10; i++)
will fail for mines having number of attributes less than 10. After looking at several mines, I've found that the number of attributes satisfying the type condition is a small number.Screenshots: Flymine![popup1](https://user-images.githubusercontent.com/43354059/77083704-ed8c0e80-6a23-11ea-8a6d-f63a928b31d9.png)
Yeastmine![popup](https://user-images.githubusercontent.com/43354059/77083728-f7157680-6a23-11ea-8c84-38f5403f9eb3.png)