search

internetarchive / Zeno

State-of-the-art web crawler 🔱
GNU Affero General Public License v3.0
83 stars 11 forks source link

Change log location #88

Closed nick2432 closed 3 months ago

nick2432 commented 4 months ago

Changes made

I updated the directory where log files are written from ./jobs/ to ./jobs/logs/. Previously, logs were being written directly to the /jobs directory, which was not the intended location. By changing the path to ./jobs/logs/, the logs will now be stored in the designated subdirectory, improving organization and making it easier to manage log files. This update helps ensure that logs are kept separate from other files in the /jobs directory, adhering to a cleaner and more logical directory structure.

Screenshots

Screenshot from 2024-07-23 10-46-17

Issue Resolved

Fixes https://github.com/internetarchive/Zeno/issues/73

CorentinB commented 4 months ago

Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs.

equals215 commented 4 months ago

Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs.

@CorentinB did it ever? Wasn't aware of that

CorentinB commented 4 months ago

Thanks @nick2432! Problem is that with this way of adding the logs path, it doesn't respect --jobs.

@CorentinB did it ever? Wasn't aware of that

Yes basically if --jobs isn't used, "logs", "warcs" etc are in the "jobs" directory, if --jobs is specified then it is put in the given directory's name, under "jobs". So "jobs/logs" becomes "jobs/whatever/logs".

CorentinB commented 4 months ago

Hi @nick2432, do you know when the PR will be finished? Let us know if you need any help.

nick2432 commented 3 months ago

Hi @nick2432, do you know when the PR will be finished? Let us know if you need any help.

sorry, ya I will start working today I had an interview, so I was giving that

nick2432 commented 3 months ago

Hi @nick2432, do you know when the PR will be finished? Let us know if you need any help.

I will take 2-3 days

CorentinB commented 3 months ago

Hi @nick2432, sorry but it took really too long. I implemented the necessary changes myself: https://github.com/internetarchive/Zeno/commit/6ab2d19552eebeba8ea591a11e8df74a1027b70f