Ensure bookreader buttons inherit body font stack

[rebecca-shoptaw]

Problem

Currently, the "Add bookmark" button in the side panel is defaulting to Arial for its font, when it should use the same Helvetica Neue font stack as the other buttons.

It seems that this is because other buttons such as the "Login" button are actually a elements styled as buttons, so they correctly inherit the body font-stack:

Whereas the default button styles for the "Add bookmark" button seem to be overriding the inheritance and defaulting to Arial:

Solution

Very simple! I just added font-family: inherit to the ia-button class, which should ensure this and any other button.ia-button elements in the side panel retain the correct inherited font:

Testing

Option 1 - demo from PR

• Go to the bookreader demo generated by the PR
• Navigate to the bookmarks section on the side panel
• Toggle the logged in view to see “Add bookmark”
  • Confirm that the font for "Add bookmark" is the same as the body font and the other buttons
• You can determine the fonts for a few other side panel buttons by:
  • Selecting “Add Bookmark” to see the “Delete”/”Save” buttons
  • Navigating to downloads (see: "Get PDF" and/or "Get ePUb")
  • Toggling the login view and returning to bookmarks (see: the "Login" button)
• Note: Because the body font in the mini demo bookreader is set to sans-serif, we should expect/want the “Add bookmark” button to also be sans-serif, the test being whether it matches all the other fonts (i.e. inherits correctly) rather than that it is Helvetica Neue
  • Feel free to try editing the global font in the dev tools to ensure all button fonts change with it!

Option 2 - dev tools in prod context Since this is a one-line fix, it can also easily be tested via the dev tools in the production site:

• Navigate to any unrestricted book
• Via the browser’s dev tools, find the ia-button class and add the line font-family: inherit
• Follow the same steps as option 1, and confirm that the font is indeed Helvetica Neue for all relevant buttons

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.30%. Comparing base (2d19d55) to head (ad1b546). Report is 7 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1337 +/- ## ======================================= Coverage 69.30% 69.30% ======================================= Files 59 59 Lines 5082 5082 Branches 1069 1069 ======================================= Hits 3522 3522 Misses 1533 1533 Partials 27 27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.