search

internetarchive / dweb-mirror

Offline Internet Archive project
https://www-dweb-mirror.dev.archive.org/
GNU Affero General Public License v3.0
263 stars 27 forks source link

node v12 requires level v5 #236

Closed JesseWeinstein closed 5 years ago

JesseWeinstein commented 5 years ago

While node v10 (the stable version) requires level v4. So if all our platforms support node v12, we can use that -- otherwise, maybe a branch?

mitra42 commented 5 years ago

I tested level v5 under node v10 and it seemed to work, I don't know why I locked level at v4, it might have been a failure to build, or that I was concerned that the v4.x - v5.x transition would break the API in some way, but a check of their docs suggests the changes don't impact any aspect we are using so I've pushed it up to level v5.