internetarchive / iaux

Monorepo for Archive.org UX development and prototyping.
GNU Affero General Public License v3.0
65 stars 86 forks source link

[ia-topnav] WEBDEV-6698 Add user menu callout on My Lists item #894

Closed latonv closed 6 months ago

latonv commented 6 months ago

Description

What does this PR achieve? Is it a feature/hotfix/refactor? Does it close an Issue? If so, use Closes #.

Adds a "NEW" callout bubble beside the new "My lists" item on the user menu of the topnav.

Technical

What should be noted about the implementation?

Adds a new config value to the topnav, callouts, for the parent to specify any callouts that should appear on menu items. This allows Offshoot's app root to specify whether or not the callout should be shown, for instance.

Testing

What steps should the reviewer take to verify this PR resolves the issue?

Load the Offshoot review app that includes these topnav changes with the appropriate AB variant override set, and open the user menu. The "My lists" item should be listed, with a "NEW" badge beside it.

Evidence

If this PR touches UI, please post evidence (screenshot) of it behaving correctly.