By Statement has gone missing

[LeadSongDog]

The "Is there a By Statement" field is not being displayed after moving an edition to a different work, although it is still available for edit in librarian mode. Three examples: https://openlibrary.org/books/OL17015085M/The_story_of_Sir_Galahad https://openlibrary.org/books/OL6718026M/Women_of_the_Morte_Darthur https://openlibrary.org/books/OL19634311M/The_birth_life_and_acts_of_King_Arthur_of_his_noble_knights_of_the_Round_Table

[LeadSongDog]

First example illustrated:

[jdlrobson]

Do you remember where it used to be? Maybe wayback machine can help here?

[LeadSongDog]

I think it was either https://github.com/internetarchive/openlibrary/blob/7195f181742af7389843f275eefb2e675055b727/openlibrary/templates/books/edit/edition.html#L345 or https://github.com/internetarchive/openlibrary/blob/10efe40c7f3b50fd5f23eaf08e9a353885dde553/openlibrary/templates/books/edition-show.html#L70

That double hyphen in the former caught my eye, but I don't think it's the problem... iiuc, the second shows the by_statement just before the edition's publish date, so in my example above, it would be before the "Published 1908..."

[LeadSongDog]

doh! The by_statement is in the json, so the edit must have worked, it simply isn't being displayed:

{"translated_from": [{"key": "/languages/fre"}], "number_of_pages": 223, "contributors": [{"role": "Illustrator", "name": "William Ernest Chapman"}, {"role": "Retold by", "name": "Mary Blackwell Sterling"}], "latest_revision": 6, "contributions": ["Sterling, Mary Blackwell."], "source_records": ["marc:marc_oregon_summit_records/catalog_files/washs02192008.mrc_revrev.mrc:1031063220:895"], "title": "The story of Sir Galahad", "translation_of": "Le morte d'Arthur", "languages": [{"key": "/languages/eng"}], "publish_country": "xx ", "by_statement": "retold from Le morte d'Arthur of Sir Thomas Malory and the original stories by Mary Blackwell Sterling; illustrations by William Ernest Chapman", "oclc_numbers": ["2835877"], "type": {"key": "/type/edition"}, "revision": 6, "publishers": ["E. P. Dutton & co."], "last_modified": {"type": "/type/datetime", "value": "2018-10-29T16:11:15.532482"}, "key": "/books/OL17015085M", "authors": [{"key": "/authors/OL170469A"}], "publish_places": ["New York"], "pagination": "xii p., 1 l., 223 p.", "classifications": {}, "created": {"type": "/type/datetime", "value": "2008-09-27T03:01:03.474285"}, "lccn": ["08032374"], "notes": {"type": "/type/text", "value": "Ornamental borders"}, "identifiers": {}, "publish_date": "1908", "works": [{"key": "/works/OL15450151W"}]}

Should it not be the edition's by_statement rather than the book's which is displayed?

[LeadSongDog]

Aha! The by statement is only being displayed on the abbreviated edition page shown below the only one edition of this book statement.

[mekarpeles]

@LeadSongDog does that mean this issue may be closed?

[LeadSongDog]

@mekarpeles No, I don't think it has been fixed yet. Viewing: https://openlibrary.org/books/OL17015085M/The_story_of_Sir_Galahad

the reader should be, but is not, displayed the text from the by_statement: "retold from Le morte d'Arthur of Sir Thomas Malory and the original stories by Mary Blackwell Sterling; illustrations by William Ernest Chapman"

[xayhewalo]

@LeadSongDog so if I'm reading this correctly. All the information to present this data is in the json, but isn't being displayed correctly?

[LeadSongDog]

@guyjeangilles That’s correct. The list of contributors is displayed but not the by_statement. Both are in the json.

[mekarpeles]

The problem is that we are not rending the by_statement field https://openlibrary.org/books/OL17015085M.json on https://openlibrary.org/books/OL17015085M.

@jimchamp