Excluded URLs aren't saving

[gouthamravee]

Describe the bug Adding exclude urls doesn't save.

To Reproduce Steps to reproduce the behavior:

1. Go to 'exclude urls' page
2. add url "*.gouthamravee.com"
3. hit save
4. close window
5. then return to 'exclude urls' page

Expected behavior After hitting save and returning to the 'exclude urls' page, I am expecting to see the url pattern I added earlier.

Screenshots https://imgur.com/a/f1qw0Nk - here's a screen recording of it happening

Environment (please complete the following information):

• Webextension version: 3.2
• Browser + version: Firefox 123.0.1 (64-bit)
• OS + version: Windows 11 x64 22H2 22621.3235

Additional context I want to make sure I have all my private domains excluded before I enable auto save. The domains are private and don't exist on the public internet, or at least don't lead to my private services. My main worry is screenshots or any html content of the page being sent to the web archive.

[cgorringe]

Hi @gouthamravee Thank you for your detailed bug report, and especially the video!

The Good News: If your websites can't be viewed on the public Internet, then they cannot be saved by the Wayback Machine.

The Not-so-good News: I'm having trouble recreating this bug, but can tell from your video that it's quite real! I tested this on macOS and not Windows though. Since it's working for me, I'm having a hard time debugging the possible cause.

Can I ask for your help to test one thing? Would you check your Settings under Sync, and tell me if that is turned ON or not? If you are signed in to Sync, could you try signing out and test the Excluded URLs feature again?

Thank you.

[gouthamravee]

The Good News: If your websites can't be viewed on the public Internet, then they cannot be saved by the Wayback Machine.

That's awesome to know, I want to make sure that the extension doesn't take a screen shot of the page to upload also.

Can I ask for your help to test one thing? Would you check your Settings under Sync, and tell me if that is turned ON or not? If you are signed in to Sync, could you try signing out and test the Excluded URLs feature again?

I signed out of sync, and that seems to have fixed the issue. Though it took a while for it to work. I didn't get a recording of it, but basically after turning off sync (browser was NOT restarted) I went to check the exclude list. At first it was completely empty, even the default values were missing. I closed the exclude urls window and opened it again, then the defaults showed up, but my custom url wouldn't save.

So I went to start up my screen recording software again, opened the exclude window, and what do you know it saves! Another screen recording to show that it works -> https://imgur.com/a/T4tAjie

Sorry I'm testing this as I'm writing the response, and I noticed after the recording if I added one of my private domains that's not public in anyway, as in its not a registered domain on the public internet, it doesn't save. Would I be correct in assuming that exclude urls page tests if a url is valid/public before saving it?

I tried a few more of my own domains that are public and all of them saved, all of the domains are similarly named.

Only the domain that's not public and not 'real' didn't save.

[cgorringe]

@gouthamravee Thanks for following up with this test.

I had a hypothesis that when Sync is turned on, it causes a delay in saving the URLs, and what happens is that the window closes before the saving takes place. If this is true, I should have the fix!

The URLs aren't checked if they are valid or public domains, so that shouldn't make any difference.

[cgorringe]

@gouthamravee if you would do one more thing and test out this bug fix, I'd appreciate it!

1. First download this ZIP file
2. Then follow these directions: Installing the Latest Build from Source

Let us know if that fixes the bug with Sync turned On!

[gouthamravee]

Worked perfectly. Thank you!