I have several transliterations set already. But I'd like you to review this one to see if I'm on track.
Thanks!
From @andrew2net
We need to define at least one test case for each transliteration system. Please add source and expected in the test section.
From @ronaldtse
We need to define at least one test case for each transliteration system. Please add source and expected in the test section.
Right, but it seems that the source reference doesn't provide any examples. Will need to find them...
From @AhMohsen46
@ronaldtse related doc is having arabic equivalents, but it's not basically arabic, I -unforunately- don't think I can do this
however, if we had no other option I may do a little bit of exploration and transliterate the 22 letter language as per the doc, but I can't guarantee a 100% of success and test coverage
From @manuel489 at https://github.com/interscript/interscript-ruby/pull/11
From @manuel489
Hi Ron,
I have several transliterations set already. But I'd like you to review this one to see if I'm on track.
Thanks!
From @andrew2net
We need to define at least one test case for each transliteration system. Please add
source
andexpected
in thetest
section.From @ronaldtse
Right, but it seems that the source reference doesn't provide any examples. Will need to find them...
From @AhMohsen46
@ronaldtse related doc is having arabic equivalents, but it's not basically arabic, I -unforunately- don't think I can do this however, if we had no other option I may do a little bit of exploration and transliterate the 22 letter language as per the doc, but I can't guarantee a 100% of success and test coverage