search

intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

Update RxCocoa/Swift/DataSource/Gesture #243

Closed MatrixSenpai closed 4 years ago

MatrixSenpai commented 4 years ago

This fixes #239 and #64

It seems like the only thing that actually needed to be changed was the dependency lines. I recommend an additional PR to bump the Pod version.

I ran this against a project using RxSwift/RxCocoa 5.1.1, Swift 5, and iOS 13 with successful results

croossin commented 4 years ago

@MatrixSenpai Awesome, we will take a look at it. Also, it seems that the CI build failed...

badrinathvm commented 4 years ago

@MatrixSenpai looks it's failing for below case 

Cannot convert value of type 'Int' to expected argument type 'RxTimeInterval' (aka 'DispatchTimeInterval')
    Command CompileSwift failed with a nonzero exit code
    Testing cancelled because the build failed.
MatrixSenpai commented 4 years ago

Ah yes. debounce now takes an enum rather than an int. Fixed in most recent push

edit @badrinathvm: it had nothing to do with a test case, the example project failed compilation

badrinathvm commented 4 years ago

thank you @MatrixSenpai for fixing it. Looks good to me.

MatrixSenpai commented 4 years ago

Can we get one more approval and merge? I'd love to be able to use this library

allygreen commented 4 years ago

Is it possible for someone to look at this pull request? It would be very much appreciated as I'd also love to use this library. @MatrixSenpai Thanks for making this change!

iamsimranjot commented 4 years ago

Hey @MatrixSenpai !! Thank you for pushing the required changes here. We are also kind of blocked on the same thing, can we merge these changes since it seemed to be approved?

moon-jerry commented 4 years ago

used this framework recently in my project and love everything in this framework, except been blocked by the same issue here. Can we please merge this pull request? thanks

moon-jerry commented 4 years ago

for those who still struggle with this issue. What I did maybe silly but effective, I grab the source code folder and manually import into my project , of course, I had to put import... in every single file, then using pod RxCocoa to update the cocoa version.

badrinathvm commented 4 years ago

Alternative approach is to use like below in your pod files until this gets merged

pod 'CardParts', :git => 'https://github.com/intuit/CardParts.git', :branch => 'MatrixSenpai:master'

allygreen commented 4 years ago

Alternative approach is to use like below in your pod files until this gets merged

pod 'CardParts', :git => 'https://github.com/intuit/CardParts.git', :branch => 'MatrixSenpai:master'

I tried that but unfortunately my pod update couldnt' find the branch. Also tried on commit but no success. Any other suggestions that might help? Appreciate your time and original suggestion!

allygreen commented 4 years ago

Apologies - I got it working using just a little tweak. I pointed the git repo to MatrixSenpai's fork like so, pod 'CardParts', :git => 'https://github.com/MatrixSenpai/CardParts.git', :branch => 'master'

Thanks, this has unblocked me till the merge goes ahead. Much appreciated.

croossin commented 4 years ago

I am sorry about the delay on this PR... we have a lot of internal applications consuming this and we need to ensure everyone is ready for the upgrade. It shouldn't be long.

sumit-nathany commented 4 years ago

@croossin I think we are ready to take this in Mint too.

croossin commented 4 years ago

This has been merged and released in version 3.0.0.