Issue when creating TaxService

[cjgratacos]

Situation: Currently we have some customers that are using the old style of taxes for QBO. Because of this, we have to use the TaxServices for creating and syncing TaxCodes.

Issue: When creating a TaxService using the QBO sdk, an exception is thrown during the JSON Deserializer interceptor. This is because of a type mismatch. When the type checker check if the type is TaxService, it is actually a type JAXBElement that wraps a TaxService, so the checker fails and deserializes the response object into a TaxCode instead of a TaxService and an exception is thrown. https://github.com/intuit/QuickBooks-V3-Java-SDK/blob/98802b1c872e3cb4e17afd6ff3756d2b6263279e/ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/DeserializeInterceptor.java#L71-L81

In short, the TaxCode gets created by the TaxService, but the request response deserialization is throwing an exception because of incorrect type and causing the request to fail.

Replicate:

• To replicate just create a Tax Service using fully the SDK.

Info:

• using the latest SDK version 6.0.4

Possible solution:

• Make a deeper type check and validate if JAXBElement and JAXBElement declaredTyped is TaxService then execute code.

[diana-derose]

Hi @cjgratacos - We'll take a look at this and update it. Please feel free to send a PR.

[shweta-intuitdev]

@cjgratacos - Can you send some code snippets of how you're creating the tax service, along with a sample JSON of the response you're receiving?

[diana-derose]

Closing this @cjgratacos please share more info and reopen if this is still happening.